Apply PR review feedback: CI hardening, lint, URL fix, code cleanup#24
Apply PR review feedback: CI hardening, lint, URL fix, code cleanup#24lord63 merged 2 commits intomigrate-ci-uvfrom
Conversation
…str() Co-authored-by: lord63 <5268051+lord63@users.noreply.github.com> Agent-Logs-Url: https://github.com/lord63/py-spin/sessions/d2ede27f-2a5b-4c50-8efc-1cdfb90920d3
There was a problem hiding this comment.
Pull request overview
This PR applies prior review feedback by tightening CI reproducibility, adding explicit linting, fixing a project metadata URL, and performing a small code cleanup in the spinner output.
Changes:
- Harden CI dependency installation by using
uv sync --dev --frozenand add aruff check .lint step. - Add
ruffto dev dependencies and regenerateuv.lockaccordingly. - Fix the project homepage URL and remove a redundant
str(...)wrapper in_spin_cursor.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
uv.lock |
Adds ruff to the locked dev dependency set. |
pyspin/spin.py |
Simplifies _spin_cursor by removing a redundant string conversion. |
pyproject.toml |
Adds ruff to the dev dependency group and updates Homepage to HTTPS. |
.github/workflows/ci.yml |
Freezes dependency sync and introduces a ruff lint step in CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| run: uv sync --dev --frozen | ||
|
|
||
| - name: Lint | ||
| run: uv run ruff check . |
There was a problem hiding this comment.
ruff check . will lint the entire repo and should fail on existing violations (e.g., example/example_spin.py has an unused loop variable i that triggers F841). To keep CI green, either fix the existing violations (use _ instead of i / remove the variable) or configure ruff to exclude example/ (or ignore F841) via pyproject.toml or CI flags.
| run: uv run ruff check . | |
| run: uv run ruff check . --exclude example |
Addresses four review comments on the modernization PR.
Changes
uv sync --dev→uv sync --dev --frozento enforce lockfile and fail fast on driftruff check .lint step so style regressions are caught in CIpyproject.toml: Addruffto dev dependencies; fix homepage URLhttp://→https://pyspin/spin.py: Remove redundantstr(...)wrapper around an already-string literal in_spin_cursoruv.lock: Regenerated to includeruff⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.